[Mini-NDN] Change in mini-ndn[master]: Add RoutingHelper to allow IP communication in experiments

[Lan Wang (lanwang)]

Begin forwarded message:

From: "Saurab Dulal (sdulal)" <sdulal at memphis.edu<mailto:sdulal at memphis.edu>>
Subject: Re: Change in mini-ndn[master]: Add RoutingHelper to allow IP communication in experiments
Date: September 18, 2019 at 12:22:26 PM CDT
To: Philipp Moll <philipp.moll at itec.aau.at<mailto:philipp.moll at itec.aau.at>>
Cc: Mini-NDN <mini-ndn-bounces at lists.cs.ucla.edu<mailto:mini-ndn-bounces at lists.cs.ucla.edu>>


Hi Philipp,

Thank you for contributing to the project, really appreciate your work.

Going forward, someone might will review it and if they find everything alright, it will be merged. If you get more comments from other people, you might have to reply, if not, your code will be merged.

Also, I will suggest you look over the guide ref below (if you haven’t gone through already) for future. It helped me a lot when I joined the project.

Contributing to the NDN Codebase: https://github.com/named-data/NFD/blob/master/CONTRIBUTING.md

Regards,
Saurab Dulal


From: Philipp Moll <philipp.moll at itec.aau.at<mailto:philipp.moll at itec.aau.at>>
Date: Wednesday, September 18, 2019 at 12:17 PM
To: "Saurab Dulal (sdulal)" <sdulal at memphis.edu<mailto:sdulal at memphis.edu>>
Subject: Re: Change in mini-ndn[master]: Add RoutingHelper to allow IP communication in experiments


Hi Saurab,

thanks for approving the commit. It's the first time I am submitting code to the named-data gerrit. Are there any other steps required before the code gets merged?

Thanks
Philipp

Am 18.09.2019 um 19:12 schrieb NDN CodeReview:

Patch Set 9:

Patch Set 8:

(3 comments)

Also, rebase is needed.

Hi Saurab,

rebased and simplified the code, as proposed in your comments.

Only difference, I did not remove the comments but added comments explaining what is done in the code instead. I am not removing comments any more because I don't think it contributes in making the code easier understandable.

Thanks, Philipp

Thanks, Philipp. The comments are fine, I was talking about redundancies. But it's ok now.

Saurab,

Patch set 9:Code-Review +1

View Change<https://gerrit.named-data.net/c/mini-ndn/+/5519>

To view, visit change 5519<https://gerrit.named-data.net/c/mini-ndn/+/5519>. To unsubscribe, or for help writing mail filters, visit settings<https://gerrit.named-data.net/settings>.

Gerrit-Project: mini-ndn
Gerrit-Branch: master
Gerrit-Change-Id: I267e264b2583909a47229279076655a8080ace22
Gerrit-Change-Number: 5519
Gerrit-PatchSet: 9
Gerrit-Owner: Philipp Moll <philipp at itec.aau.at><mailto:philipp at itec.aau.at>
Gerrit-Reviewer: Philipp Moll <mollph at gmail.com><mailto:mollph at gmail.com>
Gerrit-Reviewer: Philipp Moll <philipp at itec.aau.at><mailto:philipp at itec.aau.at>
Gerrit-Reviewer: Saurab Dulal <sdulal at memphis.edu><mailto:sdulal at memphis.edu>
Gerrit-CC: Alex Afanasyev <aa at cs.fiu.edu><mailto:aa at cs.fiu.edu>
Gerrit-CC: Junxiao Shi <sunnylandh at gmail.com><mailto:sunnylandh at gmail.com>
Gerrit-Comment-Date: Wed, 18 Sep 2019 17:12:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.lists.cs.ucla.edu/pipermail/mini-ndn/attachments/20190918/346d497c/attachment-0001.html>