<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">Begin forwarded message:</div>
<div class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class="">
<div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none; margin: 0px;" class="">
<span style="font-family: -webkit-system-font, "Helvetica Neue", Helvetica, sans-serif; color: rgb(127, 127, 127);" class=""><b class="">From:<span class="Apple-converted-space"> </span></b></span><span style="font-family: -webkit-system-font, "Helvetica Neue", Helvetica, sans-serif;" class="">"Saurab
Dulal (sdulal)" <<a href="mailto:sdulal@memphis.edu" style="color: purple; text-decoration: underline;" class="">sdulal@memphis.edu</a>><br class="">
</span></div>
<div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none; margin: 0px;" class="">
<span style="font-family: -webkit-system-font, "Helvetica Neue", Helvetica, sans-serif; color: rgb(127, 127, 127);" class=""><b class="">Subject:<span class="Apple-converted-space"> </span></b></span><span style="font-family: -webkit-system-font, "Helvetica Neue", Helvetica, sans-serif;" class=""><b class="">Re:
Change in mini-ndn[master]: Add RoutingHelper to allow IP communication in experiments</b><br class="">
</span></div>
<div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none; margin: 0px;" class="">
<span style="font-family: -webkit-system-font, "Helvetica Neue", Helvetica, sans-serif; color: rgb(127, 127, 127);" class=""><b class="">Date:<span class="Apple-converted-space"> </span></b></span><span style="font-family: -webkit-system-font, "Helvetica Neue", Helvetica, sans-serif;" class="">September
18, 2019 at 12:22:26 PM CDT<br class="">
</span></div>
<div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none; margin: 0px;" class="">
<span style="font-family: -webkit-system-font, "Helvetica Neue", Helvetica, sans-serif; color: rgb(127, 127, 127);" class=""><b class="">To:<span class="Apple-converted-space"> </span></b></span><span style="font-family: -webkit-system-font, "Helvetica Neue", Helvetica, sans-serif;" class="">Philipp
Moll <<a href="mailto:philipp.moll@itec.aau.at" style="color: purple; text-decoration: underline;" class="">philipp.moll@itec.aau.at</a>><br class="">
</span></div>
<div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none; margin: 0px;" class="">
<span style="font-family: -webkit-system-font, "Helvetica Neue", Helvetica, sans-serif; color: rgb(127, 127, 127);" class=""><b class="">Cc:<span class="Apple-converted-space"> </span></b></span><span style="font-family: -webkit-system-font, "Helvetica Neue", Helvetica, sans-serif;" class="">Mini-NDN
<<a href="mailto:mini-ndn-bounces@lists.cs.ucla.edu" style="color: purple; text-decoration: underline;" class="">mini-ndn-bounces@lists.cs.ucla.edu</a>><br class="">
</span></div>
<br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class="">
<br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class="">
<div class="WordSection1" style="page: WordSection1; caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Hi Philipp,<o:p class=""></o:p></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
<o:p class=""> </o:p></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Thank you for contributing to the project, really appreciate your work.<o:p class=""></o:p></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
<o:p class=""> </o:p></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Going forward, someone might will review it and if they find everything alright, it will be merged. If you get more comments from other people, you might have to reply, if not, your code will be merged.<o:p class=""></o:p></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
<o:p class=""> </o:p></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Also, I will suggest you look over the guide ref below (if you haven’t gone through already) for future. It helped me a lot when I joined the project.<o:p class=""></o:p></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
<o:p class=""> </o:p></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
<b class="">Contributing to the NDN Codebase:<span class="Apple-converted-space"> </span></b><a href="https://github.com/named-data/NFD/blob/master/CONTRIBUTING.md" style="color: purple; text-decoration: underline;" class="">https://github.com/named-data/NFD/blob/master/CONTRIBUTING.md</a><b class=""><o:p class=""></o:p></b></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
<o:p class=""> </o:p></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Regards,<o:p class=""></o:p></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Saurab Dulal<span class="Apple-converted-space"> </span><o:p class=""></o:p></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
<o:p class=""> </o:p></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
<o:p class=""> </o:p></div>
<div style="border-style: solid none none; border-top-width: 1pt; border-top-color: rgb(181, 196, 223); padding: 3pt 0in 0in;" class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
<b class=""><span style="font-size: 12pt;" class="">From:<span class="Apple-converted-space"> </span></span></b><span style="font-size: 12pt;" class="">Philipp Moll <<a href="mailto:philipp.moll@itec.aau.at" style="color: purple; text-decoration: underline;" class="">philipp.moll@itec.aau.at</a>><br class="">
<b class="">Date:<span class="Apple-converted-space"> </span></b>Wednesday, September 18, 2019 at 12:17 PM<br class="">
<b class="">To:<span class="Apple-converted-space"> </span></b>"Saurab Dulal (sdulal)" <<a href="mailto:sdulal@memphis.edu" style="color: purple; text-decoration: underline;" class="">sdulal@memphis.edu</a>><br class="">
<b class="">Subject:<span class="Apple-converted-space"> </span></b>Re: Change in mini-ndn[master]: Add RoutingHelper to allow IP communication in experiments<o:p class=""></o:p></span></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
<o:p class=""> </o:p></div>
</div>
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Hi Saurab,<o:p class=""></o:p></p>
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
thanks for approving the commit. It's the first time I am submitting code to the named-data gerrit. Are there any other steps required before the code gets merged?<o:p class=""></o:p></p>
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Thanks<br class="">
Philipp<o:p class=""></o:p></p>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Am 18.09.2019 um 19:12 schrieb NDN CodeReview:<o:p class=""></o:p></div>
</div>
<blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class="">
<blockquote style="border-style: none none none solid; border-left-width: 1pt; border-left-color: rgb(170, 170, 170); padding: 0in 0in 0in 8pt; margin: 7.5pt 0in; white-space: pre-wrap; word-wrap: break-word;" class="">
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif; white-space: pre-wrap; word-wrap: break-word;" class="">
Patch Set 9:<o:p class=""></o:p></p>
<blockquote style="border-style: none none none solid; border-left-width: 1pt; border-left-color: rgb(170, 170, 170); padding: 0in 0in 0in 8pt; margin: 7.5pt 0in;" class="">
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif; white-space: pre-wrap; word-wrap: break-word;" class="">
Patch Set 8:<o:p class=""></o:p></p>
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif; white-space: pre-wrap; word-wrap: break-word;" class="">
(3 comments)<o:p class=""></o:p></p>
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif; white-space: pre-wrap; word-wrap: break-word;" class="">
Also, rebase is needed.<o:p class=""></o:p></p>
</blockquote>
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif; white-space: pre-wrap; word-wrap: break-word;" class="">
Hi Saurab,<o:p class=""></o:p></p>
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif; white-space: pre-wrap; word-wrap: break-word;" class="">
rebased and simplified the code, as proposed in your comments.<o:p class=""></o:p></p>
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif; white-space: pre-wrap; word-wrap: break-word;" class="">
Only difference, I did not remove the comments but added comments explaining what is done in the code instead. I am not removing comments any more because I don't think it contributes in making the code easier understandable.<o:p class=""></o:p></p>
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif; white-space: pre-wrap; word-wrap: break-word;" class="">
Thanks, Philipp<o:p class=""></o:p></p>
</blockquote>
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif; white-space: pre-wrap; word-wrap: break-word;" class="">
Thanks, Philipp. The comments are fine, I was talking about redundancies. But it's ok now.
<o:p class=""></o:p></p>
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif; white-space: pre-wrap; word-wrap: break-word;" class="">
Saurab,<o:p class=""></o:p></p>
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Patch set 9:<span style="background-color: rgb(212, 255, 212); background-position: initial initial; background-repeat: initial initial;" class="">Code-Review +1</span><o:p class=""></o:p></p>
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
<a href="https://gerrit.named-data.net/c/mini-ndn/+/5519" style="color: purple; text-decoration: underline;" class="">View Change</a><o:p class=""></o:p></p>
<p style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
To view, visit<span class="Apple-converted-space"> </span><a href="https://gerrit.named-data.net/c/mini-ndn/+/5519" style="color: purple; text-decoration: underline;" class="">change 5519</a>. To unsubscribe, or for help writing mail filters, visit<span class="Apple-converted-space"> </span><a href="https://gerrit.named-data.net/settings" style="color: purple; text-decoration: underline;" class="">settings</a>.<o:p class=""></o:p></p>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-Project: mini-ndn<span class="Apple-converted-space"> </span><o:p class=""></o:p></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-Branch: master<span class="Apple-converted-space"> </span><o:p class=""></o:p></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-Change-Id: I267e264b2583909a47229279076655a8080ace22<span class="Apple-converted-space"> </span><o:p class=""></o:p></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-Change-Number: 5519<span class="Apple-converted-space"> </span><o:p class=""></o:p></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-PatchSet: 9<span class="Apple-converted-space"> </span><o:p class=""></o:p></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-Owner: Philipp Moll<span class="Apple-converted-space"> </span><a href="mailto:philipp@itec.aau.at" style="color: purple; text-decoration: underline;" class=""><philipp@itec.aau.at></a><o:p class=""></o:p></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-Reviewer: Philipp Moll<span class="Apple-converted-space"> </span><a href="mailto:mollph@gmail.com" style="color: purple; text-decoration: underline;" class=""><mollph@gmail.com></a><o:p class=""></o:p></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-Reviewer: Philipp Moll<span class="Apple-converted-space"> </span><a href="mailto:philipp@itec.aau.at" style="color: purple; text-decoration: underline;" class=""><philipp@itec.aau.at></a><o:p class=""></o:p></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-Reviewer: Saurab Dulal<span class="Apple-converted-space"> </span><a href="mailto:sdulal@memphis.edu" style="color: purple; text-decoration: underline;" class=""><sdulal@memphis.edu></a><o:p class=""></o:p></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-CC: Alex Afanasyev<span class="Apple-converted-space"> </span><a href="mailto:aa@cs.fiu.edu" style="color: purple; text-decoration: underline;" class=""><aa@cs.fiu.edu></a><o:p class=""></o:p></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-CC: Junxiao Shi<span class="Apple-converted-space"> </span><a href="mailto:sunnylandh@gmail.com" style="color: purple; text-decoration: underline;" class=""><sunnylandh@gmail.com></a><o:p class=""></o:p></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-Comment-Date: Wed, 18 Sep 2019 17:12:01 +0000<span class="Apple-converted-space"> </span><o:p class=""></o:p></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-HasComments: No<span class="Apple-converted-space"> </span><o:p class=""></o:p></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-Has-Labels: Yes<span class="Apple-converted-space"> </span><o:p class=""></o:p></div>
</div>
<div class="">
<div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">
Gerrit-MessageType: comment<span class="Apple-converted-space"> </span><o:p class=""></o:p></div>
</div>
</blockquote>
</div>
<br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class="">
<br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class="">
</div>
</blockquote>
</div>
<br class="">
</body>
</html>