[Nfd-dev] NDN code reviews

[Junxiao Shi]

Dear folks

As requested, this is being added to the upcoming NFD call agenda.

Yours, Junxiao


*From: *Lixia Zhang <lixia at cs.ucla.edu>
*Subject: **requesting a discussion item*
*Date: *October 19, 2020 at 7:54:08 PM PDT
*To: *Beichuan Zhang <bzhang at cs.arizona.edu>
*Cc: *Alexander Afanasyev <aa at cs.fiu.edu>, Lan Wang <lanwang at memphis.edu>,
Davide Pesavento <davide.pesavento at nist.gov>

the issue to be discussed is whether we should consider a balance between
research productivity and code quality.

during my group meeting today people brought up the issue of NDN code
review. This has been a constant topic over years, this time it is
specifically concerning how long it would take for the NDNCERT to finish
the code review

others can correct me, but according to Zhiyi and Siqi, so far the review
comments are all about coding styles, not correctness. It sounds like the
code is written in one style and the reviewer wants a different style, lots
back and forth.

We have been moving rather slowly, and my impression is that the code
review process is part of the reason.

I also heard that some others hesitate to bring code in because of the
worries about our code review process.

some students took internships in facebook and google over the summer,
apparently their code review process is not as strict as I heard.

Lixia
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.lists.cs.ucla.edu/pipermail/nfd-dev/attachments/20201020/37dd8208/attachment.html>