<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I don’t have a strong feeling that we need to standardize this part. I usually prefer something similar to what Jeff showed: variable + continuation for each .append method (modified 3a/3d). I don’t see any appealing reason to reject any of the presented styles. I can only wish that the selected way is consistent within a single module (at least .cpp/.hpp).<div class=""><br class=""></div><div class="">—</div><div class="">Alex<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 11, 2015, at 4:25 PM, Thompson, Jeff <<a href="mailto:jefft0@remap.ucla.edu" class="">jefft0@remap.ucla.edu</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii" class="">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; font-size: 14px; font-family: Calibri, sans-serif;" class="">
<div class="">I have no strong feelings. 3.(a) looks nice to me. If the first ".append" is too long you could also do:</div>
<div class=""><br class="">
</div>
<div class="">
<div style="font-family: Calibri; font-size: inherit;" class="">
<div class=""><font face="monospace,monospace" class="">return certName</font></div>
<div class=""><font face="monospace,monospace" class=""> .append(signingIdentity)</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("KEY")</font></div>
<div class=""><font face="monospace,monospace" class=""> .append(keyName.getSubName(signingIdentity.size()))</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("ID-CERT")</font></div>
<div class=""><font face="monospace,monospace" class=""> .appendVersion();</font></div>
<div class=""><font face="monospace,monospace" class=""><br class="">
</font></div>
</div>
</div>
<div class=""><br class="">
</div>
<span id="OLK_SRC_BODY_SECTION" class="">
<div style="font-family: Calibri; font-size: 11pt; text-align: left; border-width: 1pt medium medium; border-style: solid none none; padding: 3pt 0in 0in; border-top-color: rgb(181, 196, 223);" class="">
<span style="font-weight:bold" class="">From: </span>Junxiao Shi <<a href="mailto:shijunxiao@email.arizona.edu" class="">shijunxiao@email.arizona.edu</a>><br class="">
<span style="font-weight:bold" class="">Date: </span>Wednesday, March 11, 2015 at 16:17<br class="">
<span style="font-weight:bold" class="">To: </span>Jeff Thompson <<a href="mailto:jefft0@remap.ucla.edu" class="">jefft0@remap.ucla.edu</a>><br class="">
<span style="font-weight:bold" class="">Cc: </span>nfd-dev <<a href="mailto:nfd-dev@lists.cs.ucla.edu" class="">nfd-dev@lists.cs.ucla.edu</a>><br class="">
<span style="font-weight:bold" class="">Subject: </span>Re: [Nfd-dev] code-style "make incompleteness of split lines obvious" vs chained operations<br class="">
</div>
<div class=""><br class="">
</div>
<div class="">
<div class="">
<div dir="ltr" class="">Dear folks
<div class=""><br class="">
</div>
<div class="">Thanks JeffT for pointing out this snippet.</div>
<div class="">I have more questions about the alignment.</div>
<div class="">(for the example, let's assume two .append() calls cannot fit on the same line)<br class="">
</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class="">1. Why not align '.append' of subsequent lines (rule 3.23), given the part before it ("certName") is short?</div>
<div class=""><br class="">
</div>
<div class="">
<div class=""><font face="monospace,monospace" class="">certName.append(signingIdentity)</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("KEY")</font></div>
<div class=""><font face="monospace,monospace" class=""> .append(keyName.getSubName(signingIdentity.size()))</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("ID-CERT")</font></div>
<div class=""><font face="monospace,monospace" class=""> .appendVersion();</font></div>
</div>
<div class=""><font face="monospace,monospace" class=""><br class="">
</font></div>
<div class="">I feel this looks better than indent subsequent lines with two spaces.</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class="">2. What if "certName" is a shorter identifier?</div>
<div class=""><br class="">
</div>
<div class="">(a)</div>
<div class=""><br class="">
</div>
<div class="">
<div class="">
<div class=""><font face="monospace,monospace" class="">n.append(signingIdentity)</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("KEY")</font></div>
<div class=""><font face="monospace,monospace" class=""> .append(keyName.getSubName(signingIdentity.size()))</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("ID-CERT")</font></div>
<div class=""><font face="monospace,monospace" class=""> .appendVersion();</font></div>
</div>
</div>
<div class=""><font face="monospace,monospace" class=""><br class="">
</font></div>
<div class="">(b)</div>
<div class=""><br class="">
</div>
<div class="">
<div class="">
<div class=""><font face="monospace,monospace" class="">n.append(signingIdentity)</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("KEY")</font></div>
<div class=""><font face="monospace,monospace" class=""> .append(keyName.getSubName(signingIdentity.size()))</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("ID-CERT")</font></div>
<div class=""><font face="monospace,monospace" class=""> .appendVersion();</font></div>
</div>
</div>
<div class=""><font face="monospace,monospace" class=""><br class="">
</font></div>
<div class="">I feel (b) looks better.</div>
<div class=""><br class="">
</div>
<div class="">3. Suppose there's a 'return' in the front, how should I align subsequent lines?</div>
<div class=""><br class="">
</div>
<div class="">
<div class="">(a)</div>
<div class=""><br class="">
</div>
<div class="">
<div class=""><font face="monospace,monospace" class="">return certName.append(signingIdentity)</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("KEY")</font></div>
<div class=""><font face="monospace,monospace" class=""> .append(keyName.getSubName(signingIdentity.size()))</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("ID-CERT")</font></div>
<div class=""><font face="monospace,monospace" class=""> .appendVersion();</font></div>
</div>
<div class=""><font face="monospace,monospace" class=""><br class="">
</font></div>
<div class="">
<div class="">
<div class="">(b)</div>
<div class=""><br class="">
</div>
<div class="">
<div class=""><font face="monospace,monospace" class="">return certName.append(signingIdentity)</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("KEY")</font></div>
<div class=""><font face="monospace,monospace" class=""> .append(keyName.getSubName(signingIdentity.size()))</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("ID-CERT")</font></div>
<div class=""><font face="monospace,monospace" class=""> .appendVersion();</font></div>
</div>
</div>
</div>
</div>
<div class="">
<div class=""><br class="">
</div>
<div class="">
<div class="">
<div class="">(c)</div>
<div class=""><br class="">
</div>
<div class="">
<div class=""><font face="monospace,monospace" class="">return certName.append(signingIdentity)</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("KEY")</font></div>
<div class=""><font face="monospace,monospace" class=""> .append(keyName.getSubName(signingIdentity.size()))</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("ID-CERT")</font></div>
<div class=""><font face="monospace,monospace" class=""> .appendVersion();</font></div>
</div>
</div>
<div class="">
<div class="">
<div class="">(d)</div>
<div class=""><br class="">
</div>
<div class="">
<div class=""><font face="monospace,monospace" class="">return certName.append(signingIdentity)</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("KEY")</font></div>
<div class=""><font face="monospace,monospace" class=""> .append(keyName.getSubName(signingIdentity.size()))</font></div>
<div class=""><font face="monospace,monospace" class=""> .append("ID-CERT")</font></div>
<div class=""><font face="monospace,monospace" class=""> .appendVersion();</font></div>
</div>
</div>
<div class=""><br class="">
</div>
<div class="">I'd prefer (d).</div>
</div>
</div>
</div>
<div class="">(a) and (c) also look nice, in case (d) would exceed column limit.</div>
<div class="">(b) is worse than (a) and (c).</div>
<div class=""><br class="">
</div>
<div class="">Yours, Junxiao<br class="">
</div>
<div class="">
<div class="gmail_extra"><br class="">
<div class="gmail_quote">On Wed, Mar 11, 2015 at 4:06 PM, Thompson, Jeff <span dir="ltr" class="">
<<a href="mailto:jefft0@remap.ucla.edu" target="_blank" class="">jefft0@remap.ucla.edu</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex" type="cite">
<div style="word-wrap: break-word; font-size: 14px; font-family: Calibri, sans-serif;" class="">
<div class="">ndn-cxx already has plenty of code with the first option. This looks good to me. For example:</div>
<div class=""><a href="https://github.com/named-data/ndn-cxx/blob/34a37630a14c67309467074b448057dbf62cda65/src/security/key-chain.cpp#L338" target="_blank" class="">https://github.com/named-data/ndn-cxx/blob/34a37630a14c67309467074b448057dbf62cda65/src/security/key-chain.cpp#L338</a></div>
<div class=""><br class="">
</div>
<div class=""><div style="margin: 0px; font-size: 12px; font-family: Menlo;" class="">certName.append(signingIdentity)</div><div style="margin: 0px; font-size: 12px; font-family: Menlo;" class=""> .append(<span style="color:rgb(197,156,156)" class="">"KEY"</span>)</div><div style="margin: 0px; font-size: 12px; font-family: Menlo;" class=""> .append(keyName.getSubName(signingIdentity.size()))</div><div style="margin: 0px; font-size: 12px; font-family: Menlo;" class=""> .append(<span style="color:rgb(197,156,156)" class="">"ID-CERT"</span>)</div><div style="margin: 0px; font-size: 12px; font-family: Menlo; color: rgb(215, 57, 30);" class=""><span style="" class=""> .appendVersion()</span>; </div>
</div>
<div class=""><br class="">
</div>
<div class="">- Jeff T</div>
<div class=""><br class="">
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</span>
</div>
_______________________________________________<br class="">Nfd-dev mailing list<br class=""><a href="mailto:Nfd-dev@lists.cs.ucla.edu" class="">Nfd-dev@lists.cs.ucla.edu</a><br class="">http://www.lists.cs.ucla.edu/mailman/listinfo/nfd-dev<br class=""></div></blockquote></div><br class=""></div></div></body></html>