<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space; font-family: Calibri, sans-serif; font-size: 14px; color: rgb(0, 0, 0);">
<div>Hello Ju,</div>
<div><br>
</div>
<div>I updated the protobuf files for ControlParameters. Can you pull from GitHub and try again?</div>
<div><a href="https://github.com/named-data/jndn/commit/c57b13ef451ad568750c530e57eeefbaefb3f456">https://github.com/named-data/jndn/commit/c57b13ef451ad568750c530e57eeefbaefb3f456</a> </div>
<div><br>
</div>
<div>Thanks,</div>
<div>- Jeff T</div>
<div><br>
</div>
<div>On 2019/7/8, 10:20:46, "Ju Pan" <<a href="mailto:pjokk722@email.arizona.edu">pjokk722@email.arizona.edu</a>> wrote:</div>
<div><br>
</div>
<blockquote id="MAC_OUTLOOK_ATTRIBUTION_BLOCKQUOTE" style="BORDER-LEFT: #b5c4df 5 solid; PADDING:0 0 0 5; MARGIN:0 0 0 5;">
<div>Hi Jeff T,</div>
<div><br>
</div>
<div>Thanks for your reply.</div>
<div>The "Unrecognized critical type code 129" exception happened in</div>
<div>registering route process. I almost copied your TestRegisterRoute.java</div>
<div>file in jndn/example/tests directory.</div>
<div>I tried to run the standalone TestRegisterRoute.java in jNDN/example</div>
<div>directory, I got the same complain - "exception: Unrecognized critical</div>
<div>type code 129".</div>
<div>So I guess it's not the MailSync TLV def problem? And MailSync doesn't</div>
<div>have any TLV definitions as far as I know.</div>
<div><br>
</div>
<div>Let me know if I missed anything. Thanks!</div>
<div><br>
</div>
<div>Regards,</div>
<div>Ju</div>
<div><br>
</div>
<div>Here is the log:</div>
<div>------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------</div>
<div>jupan-mac:examples jupan$ mvn exec:java</div>
<div>-Dexec.mainClass="net.named_data.jndn.tests.TestRegisterRoute"</div>
<div>[INFO] Scanning for projects...</div>
<div>[WARNING]</div>
<div>[WARNING] Some problems were encountered while building the effective</div>
<div>model for net.named-data:jndn-examples:jar:test</div>
<div>[WARNING] 'dependencies.dependency.version' for</div>
<div>net.named-data:jndn:jar is either LATEST or RELEASE (both of them are</div>
<div>being deprecated) @ line 33, column 13</div>
<div>[WARNING]</div>
<div>[WARNING] It is highly recommended to fix these problems because they</div>
<div>threaten the stability of your build.</div>
<div>[WARNING]</div>
<div>[WARNING] For this reason, future Maven versions might no longer</div>
<div>support building such malformed projects.</div>
<div>[WARNING]</div>
<div>[INFO]</div>
<div>[INFO] --------------------< net.named-data:jndn-examples >--------------------</div>
<div>[INFO] Building jndn-examples test</div>
<div>[INFO] --------------------------------[ jar ]---------------------------------</div>
<div>[INFO]</div>
<div>[INFO] >>> exec-maven-plugin:1.1.1:java (default-cli) > validate @</div>
<div>jndn-examples >>></div>
<div>[INFO]</div>
<div>[INFO] <<< exec-maven-plugin:1.1.1:java (default-cli) < validate @</div>
<div>jndn-examples <<<</div>
<div>[INFO]</div>
<div>[INFO]</div>
<div>[INFO] --- exec-maven-plugin:1.1.1:java (default-cli) @ jndn-examples ---</div>
<div>exception: Unrecognized critical type code 129</div>
<div>[INFO] ------------------------------------------------------------------------</div>
<div>[INFO] BUILD SUCCESS</div>
<div>[INFO] ------------------------------------------------------------------------</div>
<div>[INFO] Total time: 0.802 s</div>
<div>[INFO] Finished at: 2019-07-08T10:14:10-07:00</div>
<div>[INFO] ------------------------------------------------------------------------</div>
<div>------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------</div>
<div><br>
</div>
<div>On Mon, Jul 8, 2019 at 8:54 AM Thompson, Jeff <<a href="mailto:jefft0@remap.ucla.edu">jefft0@remap.ucla.edu</a>> wrote:</div>
<blockquote id="MAC_OUTLOOK_ATTRIBUTION_BLOCKQUOTE" style="BORDER-LEFT: #b5c4df 5 solid; PADDING:0 0 0 5; MARGIN:0 0 0 5;">
<div><br>
</div>
<div>The meaning of “critical type code” is explained here:</div>
<div><a href="https://named-data.net/doc/NDN-packet-spec/current/tlv.html#considerations-for-evolvability-of-tlv-based-encoding">https://named-data.net/doc/NDN-packet-spec/current/tlv.html#considerations-for-evolvability-of-tlv-based-encoding</a></div>
<div><br>
</div>
<div>Type code 129 is critical because its least-significant bit is 1. "if the least significant bit of element’s TLV-TYPE number is 1, abort decoding and report an error.” The enforcement of critical type codes was added after jNDN version 0.16.</div>
<div><br>
</div>
<div>The application is using the JNDN ProtobufTlv class which uses a protobuf description file to decode TLV. It was decoding a TLV that has type code 129, but the corresponding Protobuf description does not have an field with this “critical" type code, and
so the decoding is aborted because the application doesn’t know how to handle it.</div>
<div><br>
</div>
<div>Is there anyone on this mailing list that is familiar with the TLV definitions used in MailSync?</div>
<div><br>
</div>
<div>Thanks,</div>
<div>- Jeff T</div>
<div><br>
</div>
<div>From: Ndn-interest <<a href="mailto:ndn-interest-bounces@lists.cs.ucla.edu">ndn-interest-bounces@lists.cs.ucla.edu</a>> on behalf of Avakash Bhat via Ndn-interest <<a href="mailto:ndn-interest@lists.cs.ucla.edu">ndn-interest@lists.cs.ucla.edu</a>></div>
<div>Reply-To: Avakash Bhat <<a href="mailto:bhatavakash@gmail.com">bhatavakash@gmail.com</a>></div>
<div>Date: Thursday, July 4, 2019 at 2:35:00</div>
<div>To: "<a href="mailto:ndn-interest@lists.cs.ucla.edu">ndn-interest@lists.cs.ucla.edu</a>" <<a href="mailto:ndn-interest@lists.cs.ucla.edu">ndn-interest@lists.cs.ucla.edu</a>></div>
<div>Subject: [Ndn-interest] jndn Library</div>
<div><br>
</div>
<div>I was working on a MailSync one of the open source projects that uses jndn and had some difficulty with upgrading the jndn library. The original jndn version was 0.16 and it was upgraded to 0.22 which is the most recent one. This resulted in the laptop
side application giving a protobuf error which I can't seem to solve or understand. It is giving a "Unrecognized critical type code 129" exception. The exception is occurring at the ProtobufTlv.decode line given in the below code snippet. The protobuf-java
version is 2.6.1.Are there any breaking changes that need to be considered with regards to ProtobufTlv when upgraded? Any help would be appreciated in this matter.</div>
<div>ControlParametersResponseMessage.BuilderdecodedControlResponse=</div>
<div>ControlParametersResponseMessage.newBuilder();</div>
<div>ProtobufTlv.decode(decodedControlResponse, encodedControlResponse);</div>
<div>ControlParametersResponsecontrolResponse=</div>
<div>decodedControlResponse.getControlResponse();</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>Thank you</div>
<div><br>
</div>
<div>_______________________________________________</div>
<div>Ndn-interest mailing list</div>
<div><a href="mailto:Ndn-interest@lists.cs.ucla.edu">Ndn-interest@lists.cs.ucla.edu</a></div>
<div><a href="http://www.lists.cs.ucla.edu/mailman/listinfo/ndn-interest">http://www.lists.cs.ucla.edu/mailman/listinfo/ndn-interest</a></div>
</blockquote>
<div><br>
</div>
</blockquote>
</body>
</html>